feat(RecoverWith): add recoverWith Operator #260
Conversation
srijan02420
changed the title
| next(401, -1), | ||
| next(402, -1), | ||
| complete(405) | ||
| ]) |
There was a problem hiding this comment.
Can you write a marble test instead.
src/operators/RecoverWith.ts
Outdated
|
|
||
| next(val: T): void { | ||
| this.sink.next(val) | ||
| } |
There was a problem hiding this comment.
I think we can use a mixen for this
src/operators/RecoverWith.ts
Outdated
|
|
||
| export type TSource<T> = IObservable<T> | ||
| export type TResult<R> = IObservable<R> | ||
| export type TMapper<T> = (err: Error) => T |
There was a problem hiding this comment.
T should be an observable here. Once the values are recovered there is no way to detect if the returned observable carries a value or an error.
There was a problem hiding this comment.
@tusharmath you mean source should be observable of observable?
| describe('recoverWith()', () => { | ||
| it('should only emit errors as data', () => { | ||
| const sh = createTestScheduler() | ||
| const $ = sh.Cold<number>([ |
There was a problem hiding this comment.
We will need tests for when the subscription starts and when it ends.
| EVENT.next(403, 'b'), | ||
| EVENT.next(407, 'c'), | ||
| EVENT.next(411, 'd'), | ||
| EVENT.next(604, 'z'), |
There was a problem hiding this comment.
As soon as an error is dispatched. The subscription should end. So even though the stream is firing c-#-d it should not be captured by the observer. This is a fundamental architectural assumption that is being made for all other operators.
No description provided.